[decoding] add limits to variable-length decoders #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows decoder users to limit how many characters or array elements they want to decode. Such limits are useful in a server environment because `lib0` synchronously decodes messages. An attacker just send a message with a very long string or array and stall the main thread of the server so that no other requests can be served. The length limits have been added to these public functions: - `readVarUint8Array` - `readTerminatedUint8Array` - `readVarString` - `peekVarString` - `readTerminatedString` - The constructor of `StringDecoder` Each of these functions accepts a new trailing optional argument `maxLen`. The change should therefore not be breaking. I have added some tests, the code is fully covered.
|
Wouldn't it be better to check the length of the buffer instead? If you really must check the size of Generally, I avoid polymorphism in low-level primitives. This is why this library is so fast. Hence, I don't want to accept the PR as is. Sorry for that. There are probably better ways to solve the problem you are facing. I would accept a PR that checks that the buffer is not exceeded (which is not always the case in lib0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows decoder users to limit how many characters or array elements they want to decode.
Such limits are useful in a server environment because
lib0synchronously decodes messages. An attacker just send a message with a very long string or array and stall the main thread of the server so that no other requests can be served.The length limits have been added to these public functions:
readVarUint8ArrayreadTerminatedUint8ArrayreadVarStringpeekVarStringreadTerminatedStringStringDecoderEach of these functions accepts a new trailing optional argument
maxLen. The change should therefore not be breaking.I have added some tests, the code is fully covered.