Add size limit #32
Closed
Add size limit #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviouk
commented
Oct 14, 2021
| pair: '301 B', | ||
| prng: '6.69 kb', | ||
| promise: '1.33 kb', | ||
| queue: '0 kb', |
There was a problem hiding this comment.
This one also didn't work for some reason 🤔
|
This tool is super cool! Thank you for pointing this out. It really makes sense to measure the size of "bundles" - like web apps. However, for lib0, I'm not so sure. I'm super critical about everything that goes into lib0, as it should be as minimalistic as possible. Feel free to discuss further, however, at this time, I'm not super convinced that I want to maintain this in lib0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds size limit checks into the pipeline.
Unfortunately because of lack of support of the tool, the config had to be written in .cjs and it's not able to parse pure esm yet (ai/size-limit#227)
Still I think this adds value, but let me know what you think