Skip to content

Add override keywords to ThreadedIter class to make it more explicit #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hcho3 merged 2 commits into from
Jun 7, 2024
Merged

Add override keywords to ThreadedIter class to make it more explicit #683

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc04d03
Add `override` keyword to make it more explicit.
ZJUGuoShuai Oct 22, 2023
b9b6174
Merge branch 'main' into add-override
hcho3 Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/dmlc/threadediter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ class ThreadedIter : public DataIter<DType> {
* use the other Next instead
* \return true if there is next record, false if we reach the end
*/
virtual bool Next(void) {
virtual bool Next(void) override {
if (out_data_ != NULL) {
this->Recycle(&out_data_);
}
Expand All @@ -199,12 +199,12 @@ class ThreadedIter : public DataIter<DType> {
* NOTE: the call to this function is not threadsafe
* use the other Next instead
*/
virtual const DType &Value(void) const {
virtual const DType &Value(void) const override {
CHECK(out_data_ != NULL) << "Calling Value at beginning or end?";
return *out_data_;
}
/*! \brief set the iterator before first location */
virtual void BeforeFirst(void) {
virtual void BeforeFirst(void) override {
ThrowExceptionIfSet();
std::unique_lock<std::mutex> lock(mutex_);
if (out_data_ != NULL) {
Expand Down