Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ABI version. #72

Closed
wants to merge 2 commits into from
Closed

Add ABI version. #72

wants to merge 2 commits into from

Conversation

hameerabbasi
Copy link

@hameerabbasi hameerabbasi commented May 25, 2021 •
edited
Loading

Things to be discussed:

  • Do we put the DLVersionInfo inside DLTensor? If so, this is an ABI breaking change in itself.
  • Is the naming convention okay?
  • Do we even need a function?

Fixes #34.

hameerabbasi
hameerabbasi commented May 25, 2021
View reviewed changes
include/dlpack/dlpack.h
@@ -12,8 +12,15 @@
#define DLPACK_EXTERN_C
#endif

/*! \brief The current version of dlpack */
#define DLPACK_VERSION 050
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note here, the leading 0 meant this was being stored as an octal value, so it was decimal 40.

@leofang leofang mentioned this pull request May 28, 2021
Open
@tirthasheshpatel tirthasheshpatel mentioned this pull request Mar 10, 2022
Closed
This was referenced Mar 22, 2022
Merged
Closed
@tqchen
Copy link
Member

tqchen commented Jan 5, 2023

closed in favor of #113

@tqchen tqchen closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Future ABI compatibility
2 participants
@hameerabbasi @tqchen