Conversation
Test::Unit version 0.25 is packaged by Fedora. No need for us to use a local one.
It's unused, and additionally it's packaged for Fedora.
It's unused.
This is packaged up already. Just use that version.
Member
lorelei-sakai
left a comment
lorelei-sakai
left a comment
There was a problem hiding this comment.
As mentioned in the other PR, we can't accept pull requests directly on this repo, but this is a good observation and I'll try to pull this in through perforce, to get reflected here.
Member
lorelei-sakai
left a comment
lorelei-sakai
left a comment
There was a problem hiding this comment.
We will remove the unused packages. Proc::Simple and Test::Unit are heavily used by our infrastructure, so I'm not removing those yet, but I've opened tickets to work on removing our private versions of these soon.
Member
|
The removals are now reflected on main. Since we have internal tickets for the remaining packages, and nothing really depends on them, I'd like to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you know perl/third is almost unused? I for sure didn't. In fact, the only parts that are used are Test::Unit and Proc::Simple, which -- are packaged for Fedora anyway.
I'm not using Bunsen so I have an untested change, bunsen#47 , to add Test::Unit and Proc::Simple to the perl packages over there.