Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip manufacturer name from device type #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Strip manufacturer name from device type #107

wants to merge 2 commits into from

Conversation

ananace
Copy link

@ananace ananace commented Jul 21, 2023

Several manufacturers seem to love prefixing their device identifiers with their name as well, leading to duplicated data otherwise

@ananace
Strip manufacturer name from device type
04fbd09 
Several manufacturers seem to love prefixing their device identifiers
with their name as well, leading to duplicated data otherwise
kamils-iRonin
kamils-iRonin suggested changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@kamils-iRonin kamils-iRonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, do you mind updating device_type tests to include this case?

https://github.com/dm-drogeriemarkt/foreman_netbox/blob/master/test/services/foreman_netbox/netbox_attributes_test.rb#L53

@ananace ananace requested a review from kamils-iRonin August 21, 2023 07:26
@kamils-iRonin
Copy link
Contributor

let's wait for #109, then rebase and we can merge 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamils-iRonin kamils-iRonin kamils-iRonin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ananace @kamils-iRonin