Move definitions into new file ttblue.h #16
Conversation
|
Note to self: PR should be updated if #13 is merged before this one |
Remove structs with files as they are mostly identical between V1 and V2 devices. Use similar format as the ttwatch project do, to simplify a potential future merge of the projects. Some interesting information: * There seem to be 11 bluetooth commands in total used by the android app * There are at least 3 types of notifications: phone call, text message and voice mail/misc.(?)
Add new var read_code and read -c argument into it and then strcpy into dev_code. (Mostly because I couldn't figure out how to read the popt arg into a char[])
poptGetContext returns the int specified in the 5th position in the poptOption struct.
| if (read_code != NULL) { | ||
| strcpy(dev_code, read_code); | ||
| } | ||
|
|
There was a problem hiding this comment.
Style nitpick: please remove the braces, since there's only 1 statement in 'em.
| fprintf(stderr, "Pairing code should be 6-digit number.\n"); | ||
| goto fatal; | ||
| } | ||
| fgets(dev_code, 7, stdin); |
There was a problem hiding this comment.
Please do the string-to-integer confusion here, using strtoul, rather than in the tt_authorize function.
If the code isn't a valid decimal integer, we want to catch and report it rather than silently change it to (int)0 (which is the effect of using atoi without any other validation).
There was a problem hiding this comment.
I'll dust off my v1 and v2 device and have a look at this PR again when I get some time!
| /****************************************************************************** | ||
| * Messages * | ||
| ******************************************************************************/ | ||
| #define MSG_OPEN_FILE_WRITE (0x02) |
There was a problem hiding this comment.
0x02 is defined twice in the list, seem to be an error (this line should probably be deleted)
2 participants
Remove structs with files as they are mostly identical between V1 and V2
devices. Use similar format as the ttwatch project do, as a first step for a potential future merge of the projects.
Some interesting information:
voice mail/misc.(?)