Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Change _aaNew to return Impl*, not AA #3871

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Jul 5, 2022

_aaNew was added recently in #3863.
This makes it consistent with _d_assocarrayliteralTX also returning Impl*.

I'm also hoping this will fix the test failures for some platforms with dlang/dmd#14257 as I'm using el_bin(OPcall, TYnptr not TYstruct - couldn't get the latter to work.

Also flesh out docs for _d_assocarrayliteralTX.

_aaNew was added recently in dlang#3863.
This is consistent with `_d_assocarrayliteralTX` returning `Impl*`.

Also flesh out docs for _d_assocarrayliteralTX.
@ntrel ntrel requested review from andralex and wilzbach as code owners July 5, 2022 18:11
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3871"

@dlang-bot dlang-bot merged commit 651389b into dlang:master Jul 5, 2022
@ntrel ntrel deleted the aa-new-ptr branch July 5, 2022 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants