Improve frame interpolation#4919
Open
jwt27 wants to merge 21 commits into
Open
Conversation
as this code is now reached before the current turn is subtracted
Makes the mouse light a little less flickery.
Clean up this function and match logic with get_player_coords_and_context() in front_input.c. Fixes local mouse light glitching when: - something is held in hand, and there is something under it to pick up - pointing just above/behind a door (DoorKey cursor state)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frame interpolation method used is non-linear and includes some future-prediction, which causes overshoots. #4908 works around the visual effect, but I believe it is better to use a purely linear method instead.
This did uncover some new bugs, where the previous-frame position was reset too early. Those have been fixed now.
I removed the minimap interpolation code, as it was not necessary. Both the (local) camera and all Things already have interpolated map positions, there is no need to do it twice.