feat(observer): add cache-aware token accounting by djm204 · Pull Request #3781 · djm204/frankenbeast

djm204 · 2026-07-25T16:07:34Z

Summary

add cache-read and cache-creation token fields across shared provider usage, observer counters, span metadata, and orchestrator aggregation
translate real Anthropic and OpenAI SDK cache usage without estimating unsupported fields
price cache tiers with prompt-rate fallback, export a cache-hit ratio helper, and document the accounting model
preserve safe-integer validation and atomic overflow rejection across counters and aggregators

Test plan

npm --workspace @franken/orchestrator test -- tests/unit/providers/anthropic-api-adapter.test.ts tests/unit/providers/openai-api-adapter.test.ts tests/unit/providers/token-aggregator.test.ts tests/unit/adapters/observer-adapter.test.ts tests/unit/skills/cli-skill-executor.test.ts test/adapters/cli-observer-bridge.test.ts
npm --workspace @franken/observer test -- src/cost/TokenCounter.test.ts src/cost/CostCalculator.test.ts src/core/SpanLifecycle.test.ts
npm --workspace @franken/types test -- tests/provider.test.ts
npx turbo run typecheck --filter=@franken/types --filter=@franken/observer --filter=@franken/orchestrator
npx turbo run lint --filter=@franken/types --filter=@franken/observer --filter=@franken/orchestrator
npx turbo run build --filter=@franken/types --filter=@franken/observer --filter=@franken/orchestrator

Closes #3727

djm204 · 2026-07-25T16:08:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e1366961a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

djm204 · 2026-07-25T16:21:54Z

@codex review

djm204 · 2026-07-25T16:27:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 06acd2bc72

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

djm204 · 2026-07-25T16:43:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ddae0ec49f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

djm204 · 2026-07-25T17:06:44Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d51ad8f8b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

djm204 · 2026-07-25T17:42:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26e4634bce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

djm204 · 2026-07-25T18:21:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69539be5c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

djm204 · 2026-07-25T18:32:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c95814fbac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

djm204 · 2026-07-25T18:54:00Z

@codex review

chatgpt-codex-connector · 2026-07-25T18:57:33Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 4488a4f128

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

djm204 · 2026-07-25T19:31:56Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01ac5549ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

djm204 · 2026-07-25T20:02:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0314063e10

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

djm204 · 2026-07-25T20:24:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bbabdc329e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread packages/franken-observer/src/cost/CostCalculator.ts

Comment thread packages/franken-observer/src/cost/TokenCounter.ts

djm204 force-pushed the feat/cache-aware-token-accounting-3727 branch from 7e13669 to 3b6ba7b Compare July 25, 2026 16:19

djm204 force-pushed the feat/cache-aware-token-accounting-3727 branch from 3b6ba7b to 06acd2b Compare July 25, 2026 16:27

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread packages/franken-observer/src/cost/defaultPricing.ts

Comment thread packages/franken-orchestrator/src/providers/openai-api-adapter.ts

Comment thread packages/franken-observer/src/cost/TokenCounter.ts

Comment thread packages/franken-observer/src/core/SpanLifecycle.ts

djm204 force-pushed the feat/cache-aware-token-accounting-3727 branch from 06acd2b to ddae0ec Compare July 25, 2026 16:42

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread packages/franken-observer/src/cost/TokenCounter.ts

Comment thread packages/franken-observer/src/cost/TokenCounter.ts

Comment thread packages/franken-observer/src/cost/CostCalculator.ts

Comment thread packages/franken-observer/src/cost/defaultPricing.ts

feat(observer): add cache-aware token accounting

6d51ad8

djm204 force-pushed the feat/cache-aware-token-accounting-3727 branch from ddae0ec to 6d51ad8 Compare July 25, 2026 17:03

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

fix(observer): address cache accounting review findings

26e4634

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

fix(observer): propagate one-hour cache accounting

69539be

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread packages/franken-orchestrator/src/adapters/cli-observer-bridge.ts

fix(observer): preserve one-hour CLI spend tier

c95814f

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread packages/franken-orchestrator/src/adapters/observer-adapter.ts

Comment thread packages/franken-mcp-suite/src/adapters/governor-adapter.ts

fix(observer): preserve one-hour spend repricing

4488a4f

fix(observer): keep Prometheus cache metrics out of scope

01ac554

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread packages/franken-mcp-suite/src/shared/tool-registry.ts Outdated

Comment thread packages/franken-orchestrator/src/adapters/observer-adapter.ts

fix(observer): expose one-hour cache accounting

0314063

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread packages/franken-mcp-suite/src/shared/tool-registry.ts Outdated

Comment thread packages/franken-types/src/provider.ts

fix(observer): preserve cache usage presentation

bbabdc3

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread packages/franken-orchestrator/src/network/chat-attach.ts Outdated

Comment thread packages/franken-mcp-suite/src/adapters/observer-adapter.ts

fix(telemetry): validate cache token aggregates

139d62f

djm204 merged commit 3d526f5 into main Jul 26, 2026
4 checks passed

djm204 deleted the feat/cache-aware-token-accounting-3727 branch July 26, 2026 03:35

github-actions Bot mentioned this pull request Jul 26, 2026

chore: release main #3782

Merged

chatgpt-codex-connector Bot mentioned this pull request Jul 26, 2026

docs: add Brain Vitals epic closeout ledger #3822

Merged

djm204 mentioned this pull request Jul 26, 2026

Brain Vitals: Operational Health & Resource Telemetry Dashboard (epic) #3726

Closed

3 tasks

Conversation

djm204 commented Jul 25, 2026

Summary

Test plan

Uh oh!

djm204 commented Jul 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

djm204 commented Jul 25, 2026

Uh oh!

djm204 commented Jul 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

djm204 commented Jul 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

djm204 commented Jul 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

djm204 commented Jul 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

djm204 commented Jul 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

djm204 commented Jul 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

djm204 commented Jul 25, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 25, 2026

Uh oh!

djm204 commented Jul 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment