Skip to content

fix(mcp-suite): fail closed on unreadable hook context - #3716

Merged
djm204 merged 2 commits into
mainfrom
resolve/issue-3665-security-fbeast-hook-should-fail-closed-when-gov
Jul 31, 2026
Merged

fix(mcp-suite): fail closed on unreadable hook context#3716
djm204 merged 2 commits into
mainfrom
resolve/issue-3665-security-fbeast-hook-should-fail-closed-when-gov

Conversation

@djm204

@djm204 djm204 commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Treat a configured but unreadable FBEAST_TOOL_CONTEXT_FILE as a hard hook failure
  • Prevent pre-tool governance from falling back to empty or legacy positional context
  • Add a regression proving the governor is never called when context acquisition fails

Verification

  • npm run test --workspace @franken/mcp-suite (614 passed)
  • npm run typecheck --workspace @franken/mcp-suite
  • npm run lint --workspace @franken/mcp-suite (0 errors; 26 pre-existing warnings)
  • npm run build
  • node scripts/check-hardcoded-secrets.mjs

Closes #3665

@djm204

djm204 commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4307d19790

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/franken-mcp-suite/src/cli/hook.ts
@djm204

djm204 commented Jul 31, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 0e2b546d2f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@djm204
djm204 merged commit bceb427 into main Jul 31, 2026
4 checks passed
@djm204
djm204 deleted the resolve/issue-3665-security-fbeast-hook-should-fail-closed-when-gov branch July 31, 2026 04:22
@github-actions github-actions Bot mentioned this pull request Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security: fbeast-hook should fail closed when governor context cannot be read

1 participant