Skip to content

fix(mcp): close late redaction findings - #3609

Open
djm204 wants to merge 6 commits into
mainfrom
fix/pr-3583-late-redaction-findings
Open

fix(mcp): close late redaction findings#3609
djm204 wants to merge 6 commits into
mainfrom
fix/pr-3583-late-redaction-findings

Conversation

@djm204

@djm204 djm204 commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • detect arbitrary sensitive option flags in oversized post-tool payloads
  • redact full SigV4 authorization option values
  • whole-redact structured credential tuples/pairs hidden by duplicate JSON keys
  • add regression coverage and reusable redaction lessons

Validation

  • npm test --workspace @franken/mcp-suite (612 passed)
  • npm run test:integration --workspace @franken/mcp-suite (73 passed)
  • npm run lint --workspace @franken/mcp-suite (0 errors; 26 pre-existing warnings)
  • npm run typecheck --workspace @franken/mcp-suite
  • npm run build --workspace @franken/mcp-suite

Follow-up to #3583 for Codex findings posted immediately before that PR merged.

@djm204

djm204 commented Jul 22, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed8e517faf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
@djm204

djm204 commented Jul 22, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dbd73cbbaf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
@djm204

djm204 commented Jul 22, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9707aaeaa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
Comment thread packages/franken-mcp-suite/src/cli/hook.ts
Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
@djm204

djm204 commented Jul 22, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7772d9e6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
@djm204

djm204 commented Jul 22, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 663493be60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
Comment thread packages/franken-mcp-suite/src/cli/hook.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant