Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assets for removed django-companies element #1778

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

adamzap
Copy link
Member

@adamzap adamzap commented Nov 25, 2024

The SCSS and images removed here predate even 73d29b7, so it's hard to tell when they were added. Searching shows that the images, class, and mixin are no longer used. Plus, the Rdio service was discontinued at the end of 2015, so that's a hint.

The SCSS and images removed here predate even 73d29b7, so it's hard to
tell when they were added. Searching shows that the images, class, and
mixin are no longer used. Plus, the Rdio service was discontinued at the
end of 2015, so that's a hint.
Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! This looks like some leftovers from the "case study" feature that never launched (and predates the last big redesign 10 years ago I think). There's a bit more information if you dig a bit starting from #1698 .

Thanks! 🎸

@bmispelon bmispelon merged commit 2b3b8c3 into django:main Nov 26, 2024
4 checks passed
@adamzap adamzap deleted the remove-django-companies-assets branch November 26, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants