pass request.FILES to form #189
Conversation
|
build currently failing due to 3.6 removal from ubuntu 22.04 |
|
Thanks, Python 3.6 removal is taken care in #191. |
|
Hopefully that's close to what you had in mind! |
tests/custom_comments/forms.py
Outdated
| @@ -1,5 +1,12 @@ | |||
| from django import forms | |||
There was a problem hiding this comment.
I think we can remove this line.
There was a problem hiding this comment.
required for FileField, changed to explicit import of FileField
tests/custom_comments/models.py
Outdated
| @@ -1,5 +1,7 @@ | |||
| from django.db import models | |||
|
|
|||
| from django_comments.models import Comment | |||
There was a problem hiding this comment.
The docs suggest using from django_comments.abstracts import CommentAbstractModel to create a custom comment model.
tests/custom_comments/models.py
Outdated
| @@ -1,5 +1,7 @@ | |||
| from django.db import models | |||
There was a problem hiding this comment.
required for FileField, changed to explicit import of FileField
| @@ -1,6 +1,10 @@ | |||
| from django.conf import settings | |||
|
|
|||
|
|
||
| import django_comments |
There was a problem hiding this comment.
I think we could import get_model on the line below instead.
| COMMENTS_APP='custom_comments', | ||
| ) | ||
| def testPostCommentWithFile(self): | ||
| a = Article.objects.get(pk=1) |
There was a problem hiding this comment.
I think I would rather create a new separate test class at the bottom of the file.
… for use in custom comment app tests
DominicLGit
force-pushed
the
add_request_files_to_post_comment
branch
from
9d37255 to
1866bdf
Compare
|
Think I've fixed all the required changes. |
Passing request.FILES to the CommentForm in post_comment view.
Allows for the comment form and comment model to be extended with file fields without having to override the post_comment view.
#190