Renamed "patch" to "pull request"

[bmispelon]

Django hasn't used patches in earnest in probably
a decade, it's time to move on with the reality.

[charettes]

I suppose we'll need to adjust all the contribution documentation as well though?

https://docs.djangoproject.com/en/5.1/search/?q=has%20patch

[bmispelon]

I suppose we'll need to adjust all the contribution documentation as well though?

https://docs.djangoproject.com/en/5.1/search/?q=has%20patch

Yes, definitely. I would like to see how things look like on my local version, then I'll file a PR for django/django. I'm putting the "on hold" tag on this for now.

(and thanks for you review by the way, I appreciate it ✨ )

[bmispelon]

For reference, the corresponding docs changes are tracked in https://code.djangoproject.com/ticket/35894#ticket

[sarahboyce]

Suggested change

	needs_better_patch.label = Pull request needs improvement
	needs_better_patch.label = Requested changes

maybe

[nessita]

Thank you @bmispelon for starting this crusade!

I have commented on the ticket but I really think that we should not use a platform-dependent terminology (Pull Request is a GitHub specific term). I would suggest:

• "Has proposal"
• "Has fix"
• "Has solution"

(I prefer the first one, since some proposal are not a fix nor a complete solution.)

And then: "Needs improvement" directly, considering that the other flags are "Needs docs" and "Needs tests".

[bmispelon]

Thanks for the feedback on this merge request! 🙃

I like your idea of "Needs improvement": it's shorter and matches the other two flags better.

As I wrote on Trac, I disagree your other point (and "proposal" seems too imprecise for me, plus it could be confused for the "P" of "DEP").