WsgiToAsgi: Set wsgi.input_terminated
#286
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks! We very happily use
asgiref
in @mitmproxy since the last release, thank you very much for your work here. 😃🍰Following a bug report where a user's Flask app (wrapped with asgiref) did not see request bodies (mitmproxy/mitmproxy#4717), I discovered that Flask expects a content-length header to be set, as it doesn't trust
wsgi.input
to have read-until-EOF semantics. This then fails for chunked request bodies and no body is read at all.To demonstrate this, here's a self-contained example with asgiref+Flask:
Output:
Observe in the second line that there's no request data. The fix here seems to be to signal to WSGI apps that read-until-EOF semantics actually do exist by setting
wsgi.input_terminated
(proposed in https://gist.github.com/mitsuhiko/5721547). This PR simply does that and adds a test for it.