Skip to content

Avoided shadowing of exception when rendering errors #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Apr 18, 2024

Fixes #1004

Description of the Change

This got introduced when implementing #1070 This is fixed that the pointer is not set specifically when serializer can not be retrieved.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk April 18, 2024 19:46
@n2ygk
Copy link
Contributor

n2ygk commented Apr 18, 2024

Looks like codecov is still broken despite the status page.

@n2ygk n2ygk merged commit 6ec7ad4 into django-json-api:main Apr 18, 2024
10 checks passed
@sliverc sliverc deleted the avoid_shadowing branch April 18, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation of include parameter causes unhandled exception
2 participants