Skip to content

Sort members alphabetically #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Django Commons packages.
human and not a spambot. You can explain that by being a member, they can impact repositories immediately.
3. Add the user's GitHub username to the `members` collection in
the [`terraform/production/org.tfvars`](https://github.com/django-commons/controls/blob/main/terraform/production/org.tfvars)
file.
file. Please keep the list sorted alphabetically.
```terraform
members = [
# ...
Expand All @@ -25,7 +25,7 @@ Django Commons packages.
```
4. If they requested to be on specific repository team(s), in
the [`terraform/production/repositories.tfvars`](https://github.com/django-commons/controls/blob/main/terraform/production/repositories.tfvars)
file, add them to the `members` collection.
file, add them to the `members` collection. Please keep the list sorted alphabetically.
```terraform
repositories = {
"[REPOSITORY]" = {
Expand All @@ -47,7 +47,7 @@ Django Commons packages.
a human and not a spambot. You can explain that by being a member, they can impact repositories immediately.
2. For the requested repository's team(s), in
the [`terraform/production/repositories.tfvars`](https://github.com/django-commons/controls/blob/main/terraform/production/repositories.tfvars)
file, add them to the `members` collection.
file, add them to the `members` collection. Please keep the list sorted alphabetically.
```terraform
repositories = {
"[REPOSITORY]" = {
Expand All @@ -71,7 +71,7 @@ Django Commons packages.
the [`terraform/production/repositories.tfvars`](https://github.com/django-commons/controls/blob/main/terraform/production/repositories.tfvars)
file, for the repository's key under `repositories`, add them to the `admins` collection for the
correct team. There will be two privileged teams for each repository, `*-admins` and `*-committers`, the user should
be added to the requested team.
be added to the requested team. Please keep the list sorted alphabetically.
```terraform
repositories = {
"[REPOSITORY]" = {
Expand Down
26 changes: 13 additions & 13 deletions terraform/production/org.tfvars
Original file line number Diff line number Diff line change
@@ -1,48 +1,48 @@
# Organization admins
admins = [
"tim-schilling",
"williln",
"cunla",
"ryancheley",
"Stormheg",
"cunla",
"tim-schilling",
"williln",
]
# Organization members
members = [
"browniebroke",
"codein",
"ddabble",
"g-nie",
"gav-fyi",
"jcjudkins",
"joshuadavidthomas",
"maerteijn",
"matthiask",
"Mogost",
"nanorepublica",
"Natim",
"pfouque",
"priyapahwa",
"testSchilling",
"maerteijn",
"g-nie",
"Mogost",
"browniebroke",
"ddabble",
"codein",
]

organization_teams = {
"Admins" = {
description = "django-commons administrators"
# Use maintainers for organizational teams
maintainers = [
"tim-schilling",
"williln",
"cunla",
"ryancheley",
"Stormheg",
"cunla",
"tim-schilling",
"williln",
]
}
"security-team" = {
description = "django-commons security team"
# Use maintainers for organizational teams
maintainers = [
"matthiask",
"tim-schilling",
"matthiask"
]
permission = "push"
}
Expand Down
8 changes: 4 additions & 4 deletions terraform/production/repositories.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ repositories = {
topics = []
# People with GitHub admin repo permissions
admins = [
"tim-schilling",
"williln",
"cunla",
"ryancheley",
"Stormheg",
"cunla",
"tim-schilling",
"williln",
]
# People with GitHub maintain repo permissions
committers = [
Expand Down Expand Up @@ -72,8 +72,8 @@ repositories = {
has_projects = false

admins = [
"pfouque",
"Natim",
"pfouque",
]
committers = []
members = []
Expand Down