Account for "dateless" datasets #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been a bit annoying that `--statistics=creation` reports a total count that's less than the actual number of datasets. This is because when we report by creation date, we rely on a `JOIN` between `Dataset` and `Metadata`, where the creation date comes from the `metadata.log` `pbench.date` field, which is missing from some datasets (a bit over 4,000 on the production server). This PR changes `--statistics=creation` to count all rows returned by the SQL query, but to separately report the number of empty rows where the metadata was missing: e.g., ```console [pbench@n002 /]$ pbench-report-generator --statistics=creation Dataset statistics by creation date: 154,737 from 2012-04-13 19:21 to 2024-06-13 11:26 (count includes 4,019 datasets without a date) ```
dbutenhof
added
Server
Operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a bit annoying that
--statistics=creationreports a total count that's less than the actual number of datasets. This is because when we report by creation date, we rely on aJOINbetweenDatasetandMetadata, where the creation date comes from themetadata.logpbench.datefield, which is missing from some datasets (a bit over 4,000 on the production server).This PR changes
--statistics=creationto count all rows returned by the SQL query, but to separately report the number of empty rows where the metadata was missing: e.g.,