Minor logging cleanup #3598
Merged
Minor logging cleanup #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimize cache logging: details were useful when cache management first went in, but are now disruptive during ops review.
dbutenhof
added
Server
Operations
webbnh
previously approved these changes
Jan 16, 2024
Comment on lines
+1556
to
+1561
| @dataclass | ||
| class GoalCheck: | ||
| """Report goal check""" | ||
|
|
||
| reached: bool | ||
| usage: shutil._ntuple_diskusage |
There was a problem hiding this comment.
Just for fun, you could add a method to this class which would save you from having to reference reached explicitly:
def __bool__(self):
return self.reachedthen, the change to line 1635 could be reverted back to just:
if reached_goal():Analogously line 1658. (For line 1665, you would have to coerce it with bool(). 🦐)
Merged
webbnh
pushed a commit
that referenced
this pull request
Jan 19, 2024
* Minor logging cleanup Minimize cache logging: details were useful when cache management first went in, but are now disruptive during ops review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimize cache logging: details were useful when cache management first went in, but are now disruptive during ops review.