Update the pbench_demo
script to add --server
#3508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-on to #3494, which removed the use of
PB_AGENT_SERVER_LOC
from the containerized Agentpbench
wrapper script (it turns out that the demo was depending on it...). Now that we have the--server
option onpbench-results-move
, we use that in the demo script (instead of dynamically creating an Agent config file) to specify the server location.While making the above addition, I also dusted off the demo file:
pbench
script, and if the user wants it s/he can define it in the environment when running the demo -- and reworked the comment which mentions it.NOTE: since @pravins wants this change for use over the weekend, and since this is a change to the
contrib
area, and since there aren't any reviewers around today, I'm going to go ahead and merge this once the tests pass. If someone has comments, we can iterate on them.