feat: proof of reserve p2pkh #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriiKJ
force-pushed
the
feature/proof_of_reserve_p2pkh
branch
from
6c7cc9d to
e6cceab
Compare
ivanlele
requested changes
Nov 7, 2025
DmitriiKJ
force-pushed
the
feature/proof_of_reserve_p2pkh
branch
from
07e3d0a to
43edfe5
Compare
ivanlele
reviewed
Nov 19, 2025
| finalize_mr: bool, | ||
| } | ||
|
|
||
| pub fn leafs_tomls(utxos: Vec<Utxo>, message_hash: &[u8; 32]) -> Result<()> { |
Contributor
There was a problem hiding this comment.
Try to use &[T] whenever possible instead of Vec<T>. I see that you only use utxos to create an iterator, but .iter() creates an iterator with references, and u can get the same result by doing &[T].into_iter()
ivanlele
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.