Repository navigation
fix: reject invalid webhook scheme at startup - #2
Merged
Merged
Conversation
A non-HTTPS webhook was only rejected when the first alert was delivered. watch then logged 'Delivery failed' for every alert while appearing healthy. Validate the webhook right after loading the config so both commands exit 2 before doing any work.
autoantohaki
force-pushed
the
fix/validate-webhook-at-startup
branch
from
October 22, 2026 01:29
6b735dd to
832691e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: a non-HTTPS webhook (without
--allow-http) was only rejected when the first alert was delivered.watchkept running and printed "Delivery failed" for every alert, looking healthy until something matched.After:
scanandwatchboth check the webhook right after loading the config and exit 2 with the HTTPS error before doing any work.How: the scheme check moved into
validate_webhook(), called at startup and still fromdeliver(). Added a test that runswatchwith an http:// webhook; on the old code it hangs in the watch loop.