Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added concurrency group to the pr workflow to automatically cancel previous workflow #2066

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

RabiyaF
Copy link
Member

@RabiyaF RabiyaF commented Feb 25, 2025

This is supposed to be another update for sustainability and optimising resources. I noticed when I pushed two subsequent changes, the previous workflow keep running. As can be seen in the actions list below.

image

I have added concurrency to pr.yml to stop the previous workflow.

I have tested it as well and it work fine. This can be verified from the the actions list.
image

The workflow associated with the latest commit will run and jobs from the previous commit will automatically be cancelled.
image

@RabiyaF RabiyaF force-pushed the add-concurrency-group-to-pr-workflow branch from 3198932 to f572fce Compare February 25, 2025 22:12
@RabiyaF RabiyaF changed the title Added concurrency group to the pr workflow to automatically cancel previous workflow chore: added concurrency group to the pr workflow to automatically cancel previous workflow Feb 25, 2025
@RabiyaF RabiyaF force-pushed the add-concurrency-group-to-pr-workflow branch from c319b6a to f572fce Compare February 25, 2025 22:20
@RabiyaF RabiyaF marked this pull request as ready for review February 25, 2025 22:36
@RabiyaF RabiyaF force-pushed the add-concurrency-group-to-pr-workflow branch 3 times, most recently from e45e0ec to 7c0d266 Compare March 5, 2025 19:37
@RabiyaF RabiyaF marked this pull request as draft March 6, 2025 00:26
@RabiyaF RabiyaF force-pushed the add-concurrency-group-to-pr-workflow branch from 26b42a1 to 37876e1 Compare March 6, 2025 01:12
@RabiyaF RabiyaF marked this pull request as ready for review March 6, 2025 08:47
@RabiyaF RabiyaF force-pushed the add-concurrency-group-to-pr-workflow branch from 83508cd to 37876e1 Compare March 6, 2025 09:12
@RabiyaF
Copy link
Member Author

RabiyaF commented Mar 6, 2025

I tried updating the Windows workflow by using conan 2.*. I could not fix it. I see there is a PR to disable those tests. The other issue here is the failing linux test. I think those are failing because of the steps between the unholy hack comments. It is permission error. Maybe Forks do not have the right permissions.

remote: Permission to disorderedmaterials/dissolve.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/disorderedmaterials/dissolve.git/': The requested URL returned error: 403

But what I added in this PR is the concurrency group and that is working fine.

@RabiyaF RabiyaF requested a review from rprospero March 6, 2025 11:35
@RabiyaF RabiyaF self-assigned this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant