feat: TR module added #1956
Merged
feat: TR module added #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danbr4d
requested review from
trisyoungs and
rprospero
and removed request for
trisyoungs and
rprospero
trisyoungs
previously requested changes
Jul 2, 2024
trisyoungs
reviewed
Jul 2, 2024
|
The partial tr's are far too large at the moment but the total TR looks good. Makes me think that maybe what I'm displaying is wrong and not the equation potentially. |
|
Can't figure out the issue with this one. I can't see where the large partialTR is coming from and not being output in the same way. |
Danbr4d
force-pushed
the
1950-tr-module
branch
2 times, most recently
from
a90938b
to
951db53
Compare
git push
rprospero
force-pushed
the
1950-tr-module
branch
from
dc256c2
to
d49b114
Compare
Co-authored-by: Danbr4d <[email protected]>
rprospero
approved these changes
Oct 30, 2024
rprospero
dismissed
trisyoungs’s stale review
Review handled by recent changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1950