D10-96 / DGI9-594 / DDST-918 : Recover old syn-config.xml parsing JWT handler
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.lockClick to show 92 changes in this composer.lock filePackage changes
Dev Package changes
Important Metadata Changes
Settings · Docs · Powered by Private Packagist |
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
adam-vessey
commented
Oct 12, 2023
Syn/JwtAuthenticator.php
Outdated
There was a problem hiding this comment.
This was renamed to src/JwtAuthenticator.php
Syn/JwtFactory.php
Outdated
There was a problem hiding this comment.
This was renamed to src/JwtFactory.php.
Tests/Syn/JwtAuthenticatorTest.php
Outdated
There was a problem hiding this comment.
This was renamed to tests/JwtAuthenticatorTest.php.
src/JwtAuthenticator.php
Outdated
There was a problem hiding this comment.
This was renamed/adapted from Syn/JwtAuthenticator.php.
src/JwtFactory.php
Outdated
There was a problem hiding this comment.
This was renamed/adapted from Syn/JwtFactory.php.
config/packages/monolog.yaml
Outdated
There was a problem hiding this comment.
This was added by symfony/flex's plugin dealio... could get rid of it, if we really wanted to?
config/packages/security.yaml
Outdated
There was a problem hiding this comment.
This was added by symfony/flex's plugin dealio... could get rid of it, if we really wanted to?
symfony.lock
Outdated
There was a problem hiding this comment.
This was added by symfony/flex's plugin dealio... could get rid of it, if we really wanted to?
composer.json
Outdated
Comment on lines
42
to
47
| "extra": { | ||
| "symfony": { | ||
| "allow-contrib": false, | ||
| "require": "5.4.*" | ||
| } | ||
| }, |
There was a problem hiding this comment.
This is dealt with via symfony/flex, so... added it into the mix.
tests/bootstrap.php
Outdated
There was a problem hiding this comment.
This was added by symfony/flex's plugin dealio... could get rid of it, if we really wanted to?
|
Ticket's closed; Is apparently undesired. |
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
adam-vessey
changed the title
syn-config.xml parsing JWT handlersyn-config.xml parsing JWT handler
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
Have aliases, just in case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworking away from the deprecated "guard" implementation to the newer "authenticator" mechanism.
Still need to figure out how exactly to get it wired in/configured for use in the the microservices, but should be relatively standard.