refactor(WebSocketShard): identify throttling #8888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
SpaceEEC
approved these changes
Nov 30, 2022
kyranet
requested changes
Dec 1, 2022
packages/ws/src/strategies/context/WorkerContextFetchingStrategy.ts
Outdated
Show resolved
Hide resolved
packages/ws/src/strategies/context/WorkerContextFetchingStrategy.ts
Outdated
Show resolved
Hide resolved
kyranet
approved these changes
Dec 1, 2022
vladfrangu
approved these changes
Dec 2, 2022
didinele
force-pushed
the
refactor/identify-throttling
branch
from
4fad2a3 to
62f43bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR makes
IContextFetchingStrategyresponsible for throttling identifies.Prior to those changes, control over not spamming identify was handed to
WebSocketShard#connect's caller, which does NOT work correctly in the case of multiple shards reconnecting at the same time (e.g. there would be no regard tomax_concurrency).With this change,
/sharder(see #8859) can now also get everything working even with cross-process sharding and such.Status and versioning classification: