Skip to content

fix(GuildEmojiManager)!: Allow CreateGuildExpressions for retrieving author data #11283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
Merged

fix(GuildEmojiManager)!: Allow CreateGuildExpressions for retrieving author data #11283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0268894
fix(GuildEmojiManager): allow `CreateGuildExpressions`
Jiralite Nov 19, 2025
8f988e7
fix!: update error code
Jiralite Nov 19, 2025
514f47b
Merge branch 'main' into fix/author-emoji-fetch
Jiralite Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/discord.js/src/errors/ErrorCodes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
*
* @property {'EmojiType'} EmojiType
* @property {'EmojiManaged'} EmojiManaged
* @property {'MissingManageGuildExpressionsPermission'} MissingManageGuildExpressionsPermission
* @property {'MissingGuildExpressionsPermission'} MissingGuildExpressionsPermission
*
* @property {'NotGuildSoundboardSound'} NotGuildSoundboardSound
* @property {'NotGuildSticker'} NotGuildSticker
Expand Down Expand Up @@ -217,7 +217,7 @@ const keys = [

'EmojiType',
'EmojiManaged',
'MissingManageGuildExpressionsPermission',
'MissingGuildExpressionsPermission',

'NotGuildSoundboardSound',
'NotGuildSticker',
Expand Down
4 changes: 2 additions & 2 deletions packages/discord.js/src/errors/Messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ const Messages = {

[ErrorCodes.EmojiType]: 'Emoji must be a string or GuildEmoji/ReactionEmoji',
[ErrorCodes.EmojiManaged]: 'Emoji is managed and has no Author.',
[ErrorCodes.MissingManageGuildExpressionsPermission]: guild =>
`Client must have Manage Guild Expressions permission in guild ${guild} to see emoji authors.`,
[ErrorCodes.MissingGuildExpressionsPermission]: guild =>
`Client must have Create Guild Expressions or Manage Guild Expressions permission in guild ${guild} to see emoji authors.`,

[ErrorCodes.NotGuildSoundboardSound]: action =>
`Soundboard sound is a default (non-guild) soundboard sound and can't be ${action}.`,
Expand Down
4 changes: 2 additions & 2 deletions packages/discord.js/src/managers/GuildEmojiManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,8 @@ class GuildEmojiManager extends CachedManager {

const { me } = this.guild.members;
if (!me) throw new DiscordjsError(ErrorCodes.GuildUncachedMe);
if (!me.permissions.has(PermissionFlagsBits.ManageGuildExpressions)) {
throw new DiscordjsError(ErrorCodes.MissingManageGuildExpressionsPermission, this.guild);
if (!me.permissions.any(PermissionFlagsBits.CreateGuildExpressions | PermissionFlagsBits.ManageGuildExpressions)) {
throw new DiscordjsError(ErrorCodes.MissingGuildExpressionsPermission, this.guild);
}

const data = await this.client.rest.get(Routes.guildEmoji(this.guild.id, resolvedEmoji.id));
Expand Down
2 changes: 1 addition & 1 deletion packages/discord.js/typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4051,7 +4051,7 @@ export enum DiscordjsErrorCodes {

EmojiType = 'EmojiType',
EmojiManaged = 'EmojiManaged',
MissingManageGuildExpressionsPermission = 'MissingManageGuildExpressionsPermission',
MissingGuildExpressionsPermission = 'MissingGuildExpressionsPermission',

NotGuildSoundboardSound = 'NotGuildSoundboardSound',
NotGuildSticker = 'NotGuildSticker',
Expand Down