fix(GuildChannel): correctly handle empty permission overwrites #11222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
|
Duplicate of #11221 |
Author
|
@vakiliner how please? |
Contributor
|
@emiedonmokumo, I don't understand English very well |
Contributor
Why do I have a feeling this was written by AI? |
Author
|
Hi @almostSouji, was hoping to get a response from you... |
Member
|
Duplicate of #11221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Previously, permissionsLocked returned true for any empty overwrite, causing
channels with empty user or role overwrites to appear locked. This change limits
the "locked" behavior to only the @everyone overwrite (id === guild.id), which
matches Discord's expected permission inheritance behavior.
Link to Issue: #11190
Status and versioning classification: