Skip to content

types(ApplicationEmoji): fix animated, author and name props #10905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

idango10
Copy link

Please describe the changes this PR makes and why it should be merged:

Fixes: #10858

The properties animated, author and name shouldn't accept null for ApplicationEmoji as described in the issue.

Status and versioning classification:

Copy link

vercel bot commented May 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 19, 2025 11:28pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 19, 2025 11:28pm

Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JS counterparts of this also need updating

@Jiralite
Copy link
Member

Superseded by #10913.

@Jiralite Jiralite closed this May 26, 2025
@github-project-automation github-project-automation bot moved this from Review in Progress to Denied in discord.js May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incorrect typing for ApplicationEmoji
3 participants