refactor!: Invite classes #10888
Open
refactor!: Invite classes #10888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Jiralite
changed the title
Qjuh
requested changes
May 7, 2025
Respecting the documentation as the channel object is not documented to emit with `INVITE_DELETE`, despite it doing so.
Qjuh
requested changes
May 7, 2025
Co-authored-by: Qjuh <[email protected]>
Sweepers only sweeps guild invites.
Qjuh
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Depending on the invite type, an invite class will be created, similar to components. This has the added benefit of stronger typings: group direct message invites cannot be deleted, they do not have
target_application, etc.The separation of properties was done per the API specification:
GuildInviteGroupDMInviteFriendInvite(discord/discord-api-docs#3659) was not created as applications can no longer seem to fetch them (returns unknown invite).No other properties were added as they were not in the documentation.
Also contains miscellaneous fixes:
This nullish coalescing operator here was redundant, as adding channels already has a cache check.
this.channel =
this.client.channels._add(data.channel, this.guild, { cache: false }) ??
this.client.channels.resolve(this.channelId);
refactor!: Invite classes #10888 (comment)discord.js/packages/discord.js/src/structures/Invite.js
Lines 181 to 183 in 432cdbe
with_countsis now configurable when fetching an inviteStatus and versioning classification: