Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update undici's version #10729

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: update undici's version #10729

wants to merge 2 commits into from

Conversation

Neodevils
Copy link

Please describe the changes this PR makes and why it should be merged:
Because of a non-vulnerable version.

Status and versioning classification:

Use of Insufficiently Random Values in undici

I have updated it is version from 6.20.0 to ^6.20.1.

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@Neodevils
Updated udinci's version
c178b89 
Because of a non-vulnerable version with this reason:
> Use of Insufficiently Random Values in undici
I have updated it is version from "6.20.0" to "^6.20.1".
@Neodevils Neodevils requested a review from a team as a code owner January 26, 2025 12:50
@vercel Vercel
Copy link

vercel bot commented Jan 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2025 1:38pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2025 1:38pm

@Neodevils Neodevils changed the title Updated udinci's version fix: Updated udinci's version Jan 26, 2025
almeidx
almeidx requested changes Jan 26, 2025
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other packages that have this dependency. Those should be bumped as well

You also need to update the lockfile by running pnpm install

@Neodevils
Copy link
Author

There are other packages that have this dependency. Those should be bumped as well

You also need to update the lockfile by running pnpm install

I saw it only on discord.js and discord.js/rest packages.

@almeidx
Copy link
Member

almeidx commented Jan 26, 2025

These packages have undici as a dependency or dev dependency:

@discordjs/actions
discord.js
@discordjs/proxy
@discordjs/rest
@discordjs/scripts
@discordjs/ws

@Neodevils
Copy link
Author

These packages have undici as a dependency or dev dependency:

@discordjs/actions
discord.js
@discordjs/proxy
@discordjs/rest
@discordjs/scripts
@discordjs/ws

I am sick right now, I will update it when I get better. Thanks for reminding me.

@Neodevils Neodevils marked this pull request as draft January 26, 2025 14:05
@kyranet kyranet changed the title fix: Updated udinci's version fix: update undici's version Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx requested changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@ckohen ckohen Awaiting requested review from ckohen ckohen is a code owner automatically assigned from discordjs/rest

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/rest

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/rest

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/rest

@didinele didinele Awaiting requested review from didinele didinele is a code owner automatically assigned from discordjs/rest

@Jiralite Jiralite Awaiting requested review from Jiralite Jiralite is a code owner automatically assigned from discordjs/rest

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
packages:rest
Projects
discord.js
Status: Review in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neodevils @almeidx @SpaceEEC