Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove parameter reassignment #10715

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: remove parameter reassignment #10715

wants to merge 2 commits into from

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Reassigner, no reassigning

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel Vercel
Copy link

vercel bot commented Jan 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 4:02pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 4:02pm

@sdanialraza sdanialraza force-pushed the refactor/reassigner-no-reassigning branch 3 times, most recently from c328b8d to 78b95fa Compare January 25, 2025 20:45
@sdanialraza sdanialraza marked this pull request as ready for review January 25, 2025 20:50
@sdanialraza sdanialraza requested a review from a team as a code owner January 25, 2025 20:50
@sdanialraza sdanialraza force-pushed the refactor/reassigner-no-reassigning branch from 78b95fa to 15ca9da Compare January 31, 2025 17:52
@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Feb 4, 2025
almeidx
almeidx requested changes Feb 4, 2025
View reviewed changes
packages/discord.js/src/managers/GuildEmojiManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Webhook.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Webhook.js Outdated Show resolved Hide resolved
@sdanialraza sdanialraza requested a review from almeidx February 5, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@almeidx almeidx Awaiting requested review from almeidx

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
packages:discord.js refactor semver:patch
Projects
discord.js
Status: Review in Progress
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sdanialraza @almeidx @Jiralite