-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PartialGroupDMChannel): add missing ownerId property #10502
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Yeah it's optional because it can be missing for other channel types, my thinking was it would always be present for GroupDMs, but now that you mention it, looking at other djs structures (ThreadChannel) it accounts for that. So I think I should stick to the library behavior |
8a3bdbb
to
4d51ba4
Compare
3b615c7
to
e0154a4
Compare
e0154a4
to
aceb5b3
Compare
I noticed |
Please describe the changes this PR makes and why it should be merged:
I noticed
ownerId
was missing fromPartialGroupDMChannel
. This PR fixes that.While looking at the api documentation alone, it is hard to determine for me if the
owner_id
can be missing for Group DM Channel's, but from my testing so far, I found it to be always present. So taking that at face valueStatus and versioning classification: