Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace jest with vitest #10472

Merged
merged 11 commits into from
Oct 6, 2024
Merged

Conversation

nyapat
Copy link
Contributor

@nyapat nyapat commented Sep 2, 2024

Please describe the changes this PR makes and why it should be merged:

This is to update voice to use vitest instead of jest. It was ignored previously because the mocks are annoying to convert.
The tests compile and pass as shown by the CI.

Status and versioning classification:

@nyapat nyapat requested a review from a team as a code owner September 2, 2024 13:00
Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2024 2:24pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2024 2:24pm

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.98%. Comparing base (04df3c4) to head (9e37c66).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10472      +/-   ##
==========================================
+ Coverage   35.36%   37.98%   +2.62%     
==========================================
  Files         240      239       -1     
  Lines       14616    15484     +868     
  Branches     1220     1366     +146     
==========================================
+ Hits         5169     5882     +713     
- Misses       9400     9587     +187     
+ Partials       47       15      -32     
Flag Coverage Δ
voice 72.23% <ø> (+8.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite changed the title feat(voice): vitest test(voice): Add vitest Sep 8, 2024
@Jiralite Jiralite added the tests label Sep 8, 2024
@vladfrangu
Copy link
Member

Can you try to rebase your PR? Just start the rebase, and every time you get a merge issue on pnpm-lock.yaml, just run pnpm i. It'll solve itself

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a vitest config file for this too 🙏 Personally don't like relying on defaults

@kodiakhq kodiakhq bot merged commit 24128a3 into discordjs:main Oct 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants