feat(Interactions)!: member objects for uncached guilds #10195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
vladfrangu
previously requested changes
Mar 29, 2024
There was a problem hiding this comment.
There's a LOT of inconsistencies between trying to make this a non-semver major change (by also having snake_case properties) and a semver-major change (by not exposing all values under the same name). Let's pick one side (and gut says you want this in a sem-minor 👀) and roll with it!
nickisn't exposed asnick, onlynicknamedata.rolesisn't exposed at all, only asroleIds- this one I understand why, but I'd at least try to make uncachedMember.roles be our role manager (it should work)
Qjuh
suggested changes
Mar 29, 2024
NotSugden
suggested changes
Mar 29, 2024
Co-Authored-By: Vlad Frangu <[email protected]> Co-Authored-By: Qjuh <[email protected]>
|
Marking the PR as both sem minor and major until I test it out and ensure this is a sem-minor PR 👀 |
Qjuh
reviewed
Apr 5, 2024
NotSugden
suggested changes
Apr 9, 2024
Jiralite
reviewed
Apr 10, 2024
vladfrangu
reviewed
Apr 30, 2024
advaith1
changed the title
|
Since this PR targets d.js v15 now, I've done some changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
fixes #10010
Discord thread
Currently, when an interaction is received from a guild that isn't cached*, raw API member objects are returned instead of a d.js GuildMember object. This PR creates a new MinimalGuildMember object that is returned instead of raw API member objects.
This new object tries to be compatible with GuildMember, but retains backwards compatibility with APIGuildMember as to not make this a breaking change. Therefore it is still somewhat awkward and not great, but it is much better than just receiving an APIGuildMember. Hopefully in v15 we can remove the backwards compatibility and align it better with GuildMember.Since we're targeting v15 now, this PR updates GuildMember to extend MinimalGuildMember. all fields that do not require the guild are in MinimalGuildMember, and GuildMember adds the fields that use the cached guild.
This has not been fully tested and likely needs changes - please thoroughly review!
* This was always possible by adding apps with only the applications.commands scope, but user apps makes this a much more common appearance. This PR is based on the discord.js patch AdvaithBot is running to properly handle user app commands.
Status and versioning classification: