Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Gateway): add VoiceChannelEffectSend event #739

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

advaith1
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Adds the VoiceChannelEffectSend gateway event

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 9:19am

deno/gateway/v10.ts Outdated Show resolved Hide resolved
deno/gateway/v10.ts Outdated Show resolved Hide resolved
Comment on lines +1679 to +1682
/**
* The filename of the soundboard default sound, for soundboard effects
*/
sound_override_path?: string | null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not documented. Either mark as @unstable (if this is still included in the payload) or just get rid of it

emoji?: APIEmoji | null;
/**
* The type of emoji animation, for emoji reaction and soundboard effects
* See https://discord.com/developers/docs/topics/gateway-events#voice-channel-effect-send-animation-types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* See https://discord.com/developers/docs/topics/gateway-events#voice-channel-effect-send-animation-types

sound_volume?: number;
}

export enum VoiceChannelEffectSendAnimationType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export enum VoiceChannelEffectSendAnimationType {
/**
* https://discord.com/developers/docs/topics/gateway-events#voice-channel-effect-send-animation-types
*/
export enum VoiceChannelEffectSendAnimationType {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants