fix(rest/oauth2): correct string literal types containing bot scope #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vladfrangu
previously approved these changes
Sep 18, 2024
almeidx
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Minor fixes for the
scopeproperty type unions within the bot-specific query interfaces in rest/oauth2:OAuth2Scopes.Bot) in a template literal, so that passingscope: "bot"is valid and doesn't raise a compilation error.%20a valid space. For the parameters to exist in object form, they are by definition not yet URL-encoded, and passing a property likescope: "bot%20identify"to URLSearchParams would just re-encode the percent sign, resulting in an invalid OAuth2 query."activities.read bot identify"). Previously, this string would raise a compilation error, due to the misplaced final space in the template literal type.