🚧 Initial Discord message components v2 implementation#1294
Merged
valzargaming merged 29 commits intomasterfrom Apr 24, 2025
Merged
🚧 Initial Discord message components v2 implementation#1294valzargaming merged 29 commits intomasterfrom
valzargaming merged 29 commits intomasterfrom
Conversation
Member
|
The v2 contract was an excellent idea, and something I'd like to see in other parts of the library. It would certainly cut down on a lost of instances of checking against hardcoded types like this. |
SQKo
suggested changes
Feb 23, 2025
SQKo
suggested changes
Feb 23, 2025
Contributor
SQKo
left a comment
SQKo
left a comment
There was a problem hiding this comment.
Please also adjust the class implements Components\xx to have the namespace imported per my previous suggestion
| public function setUrl(string $url): self | ||
| { | ||
| $this->url = $url; | ||
|
|
Contributor
There was a problem hiding this comment.
Implement validation of $url like in Embed::ensureValidUrl()
Member
There was a problem hiding this comment.
Do we know if it's the same spec? We could just copy-paste the function here and do the same thing.
Member
There was a problem hiding this comment.
I've confirmed it's exactly the same except for File, in which case only attachment is allowed.
Contributor
|
According to the spec, using the components v2 may disable content and embeds, it would be good to warn the users in the MessageBuilder to avoid confusion Also seems this PR has not supported webhooks yet |
Exanlv
reviewed
Feb 25, 2025
Exanlv
reviewed
Feb 25, 2025
Co-authored-by: SQKo <87897282+SQKo@users.noreply.github.com>
Co-authored-by: SQKo <87897282+SQKo@users.noreply.github.com>
Co-authored-by: SQKo <87897282+SQKo@users.noreply.github.com>
Co-authored-by: SQKo <87897282+SQKo@users.noreply.github.com>
Co-authored-by: SQKo <87897282+SQKo@users.noreply.github.com>
Co-authored-by: SQKo <87897282+SQKo@users.noreply.github.com>
PHPDoc specifies the current restrictions on Thumbnail and Button, but the datatype should be left open as Component for now as this list of possible returns may be subject to change.
Co-authored-by: SQKo <87897282+SQKo@users.noreply.github.com>
It always returns 0 if it would otherwise be null
Co-authored-by: SQKo <87897282+SQKo@users.noreply.github.com>
Co-authored-by: Exanlv <51094537+Exanlv@users.noreply.github.com>
valzargaming
previously approved these changes
Apr 9, 2025
valzargaming
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 Work in progress.
Completely blind & untested. Should be able to try it later today.
Edit: everything appears to be functional.