chore: Reduce build size by importing core-js #641
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something seems wrong with our config, just with this change it seems the size of included core-js functions is reduced 4 times...
|
I forgot to create this PR a while back. But I think we are just missing the |
|
@lutangar I don’t see how it reduces the build size, since we’re still importing it another way … Did you test this with |
Yes I did, but things might have change since then. Maybe it would look less like webpack voodoo magic today.... |
|
@lutangar I’m still not convinced this makes any difference … Could you try to rebase and check ? Or do we close it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something seems wrong with our config, just with this change it seems the size of included core-js functions is reduced 4 times...