BaseBadge Component #16
Conversation
| // router-link is not displaying correctly in Histoire | ||
| return 'a'; |
There was a problem hiding this comment.
But this should be a router-link? In that case, lets fix the problem in Histoire rather than in the website codebase itself 👍🏻
There was a problem hiding this comment.
Can you give me some guidance on how you would you fix the problem in Histoire?
There was a problem hiding this comment.
Looks like the problem wasn't histoire in the first place! You were trying to set an href on a router-link, but router-link uses to instead of href for local pages 👍🏻 For this badge, be aware that you need to use <a> for links to pages outside of the website, and <router-link> for pages within
There was a problem hiding this comment.
Ahh - it was me 😆
Too used to using NuxtLink instead of router-link.
There was a problem hiding this comment.
Here's the source for it
https://github.com/nuxt/nuxt/blob/main/packages/nuxt/src/app/components/nuxt-link.ts
It has some niceties built-in like prefetching and handling external links.
Is there an easy way to just use it inside of a Nuxt project vs a Vue project (docs)?
There was a problem hiding this comment.
Is there an easy way to just use it inside of a Nuxt project vs a Vue project (docs)?
No idea, though I have my doubts it'll just work outside of the Nuxt context (as it's so dependent on the router and some other magic). It does raise the question though: should we rework the docs to Nuxt as well?
There was a problem hiding this comment.
You mean adding Nuxt to context of Histoire?
There was a problem hiding this comment.
It does raise the question though: should we rework the docs to Nuxt as well?
I think so. Eventually...
I like VitePress and it's super easy to get started with but there are lots of little specific quirks that I've struggled to sort out.
But Nuxt has it's own quirks too.
To me it makes sense that it's all unified though.
There was a problem hiding this comment.
You mean adding Nuxt to context of Histoire?
No not really. I was just meaning if there was an easy way to say in this components package ..
hey if this is a nuxt project use
nuxt-linkif not userouter-link
There was a problem hiding this comment.
No not really. I was just meaning if there was an easy way to say in this components package ..
hey if this is a nuxt project use nuxt-link if not use router-link
For later: Something like this sounds like a good idea in order to be able to unify the components. For Nuxt we could maybe inject nuxt-link in the module setup file.
|
Closing in favor of #22. |
No description provided.