Skip to content

test(synapse): use neutral fixture hostname in mutation-exec tests #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmagar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test(synapse): use neutral fixture hostname in mutation-exec tests #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60989bb
test(synapse): use neutral fixture hostname in mutation-exec tests
jmagar Aug 5, 2026
ec2b099
Merge branch 'main' into fix/mutation-exec-devhost-fixture
jmagar Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/shared/operations/infra/src/process_host_exec_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ impl CommandExecutor for MockExecutor {
}

fn host() -> HostRecord {
HostRecord::new(HostId::new("dookie").unwrap(), HostEndpoint::Local)
HostRecord::new(HostId::new("devhost").unwrap(), HostEndpoint::Local)
}

fn request(command: HostExecCommand, args: Vec<String>) -> HostExecRequest {
Expand Down
4 changes: 2 additions & 2 deletions crates/synapse/application/src/mutation_exec_result_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use super::*;
#[test]
fn evidence_uris_preserve_execution_identity() {
assert_eq!(
exec_evidence_uri("host-exec", "dookie", "rg"),
"host-exec://dookie/rg"
exec_evidence_uri("host-exec", "devhost", "rg"),
"host-exec://devhost/rg"
);
}
6 changes: 3 additions & 3 deletions crates/synapse/application/src/mutation_exec_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ async fn container_exec_binds_argv_and_returns_canonical_output() {
let runtime = runtime(container.clone(), hosts, true);
let operation = op("container.exec");
let parameters = json!({
"host":"dookie",
"host":"devhost",
"container_id":"api",
"command":["printf","ok"],
"exec_workdir":"/app",
Expand Down Expand Up @@ -152,12 +152,12 @@ async fn execution_parameter_drift_rejects_before_driver_send() {
let runtime = runtime(container.clone(), hosts, true);
let operation = op("container.exec");
let planned = json!({
"host":"dookie",
"host":"devhost",
"container_id":"api",
"command":["printf","ok"]
});
let changed = json!({
"host":"dookie",
"host":"devhost",
"container_id":"api",
"command":["printf","changed"]
});
Expand Down
6 changes: 3 additions & 3 deletions crates/synapse/application/tests/support/mutation_exec_support.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ pub(crate) fn host(name: &str) -> HostRecord {

pub(crate) fn container_receipt(exit_code: i64) -> ContainerExecReceipt {
ContainerExecReceipt {
host: HostId::new("dookie").unwrap(),
topology_revision: host("dookie").revision().clone(),
host: HostId::new("devhost").unwrap(),
topology_revision: host("devhost").revision().clone(),
container: "api".into(),
command: vec!["printf".into(), "ok".into()],
user: None,
Expand All @@ -114,7 +114,7 @@ pub(crate) fn runtime(
enabled: bool,
) -> SynapseMutationRuntime {
let snapshot =
TopologySnapshot::new([host("dookie"), host("alpha"), host("bad"), host("lost")]).unwrap();
TopologySnapshot::new([host("devhost"), host("alpha"), host("bad"), host("lost")]).unwrap();
SynapseMutationRuntime::new(SynapseMutationPorts {
hosts: Arc::new(StaticHosts(snapshot)),
docker: Arc::new(UnusedLifecycle),
Expand Down
Loading