Skip to content

chore: align repository with fleet CI contracts - #4

Open
jmagar wants to merge 3 commits into
mainfrom
codex/fleet-alignment-20260730
Open

chore: align repository with fleet CI contracts#4
jmagar wants to merge 3 commits into
mainfrom
codex/fleet-alignment-20260730

Conversation

@jmagar

@jmagar jmagar commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Rewrites .github/workflows/ci.yml and adds .github/workflows/release.yml to align with the fleet CI/release contract, plus .github/actionlint.yaml
  • Bumps Go and npm dependencies (go.mod/go.sum, web/package.json/web/package-lock.json) and updates docs/frontend-migration.md
  • Follow-up commit refreshes the fleet workflows further and drops the ARM build target from CI/release/Jenkinsfile

Test plan

  • CI workflow runs green on this branch
  • Release workflow dry-run/lint passes

jmagar added 3 commits July 30, 2026 19:49
…sbom scans

- backend and backend-evidence reinstall the CGO build headers
  (libjpeg/libtiff/libpng/libwebp/libraw/libheif/libgif/libvips/libav*)
  that plg_image_c, plg_image_light, and plg_video_transcoder need; without
  them go vet/test/govulncheck fail on missing pkg-config packages. Since
  fast-go.yml's vulnerability sub-job has no command hook to install them,
  backend is now a bespoke job instead of a fast-go.yml call.
- frontend's contract-command now runs `npm run build` first and passes an
  explicit path to check-web-assets.sh: fast-node.yml always runs
  build-command after contract-command, so the Next.js export never existed
  when build-embed.mjs (--skip-build) ran, and check-web-assets.sh's
  cwd-relative default path pointed at web/public instead of ../public
  once the job's working-directory became web.
- restore the per-PR sbom (CycloneDX) and image (docker build, smoke test,
  Trivy scan) jobs that fast-go.yml/fast-node.yml adoption dropped from CI,
  wired into the gate's required results.

files.test.tsx's 20s timeout is pre-existing on main (no diff to that file
since the merge-base) and is not addressed here.
@jmagar

jmagar commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator Author

Pushed a follow-up commit addressing review findings on this branch:

  • Backend native deps restored. backend and backend-evidence reinstall the CGO headers (libjpeg/libtiff/libpng/libwebp/libraw/libheif/libgif/libvips/libav*) that plg_image_c, plg_image_light, and plg_video_transcoder need to compile. fast-go.yml's vulnerability sub-job has no command hook to install system packages, so backend is now a bespoke job (matching backend-evidence's existing pattern) instead of a fast-go.yml call — verified locally: go vet, go test, and govulncheck all get past the previously-failing pkg-config/cgo stage once the deps are installed.
  • Frontend build/contract ordering fixed. fast-node.yml always runs build-command after contract-command, so npm run build never ran before build-embed.mjs --skip-build needed the Next.js export. npm run build is now the first step of contract-command (with build-command left unset). Also fixed check-web-assets.sh's cwd-relative default path, which pointed at web/public/assets/_next instead of the real ../public/assets/_next once this job's working-directory became web. Verified by running the full contract-command chain locally.
  • Restored the per-PR sbom (CycloneDX) and image (docker build, health-checked smoke test, Trivy CRITICAL/HIGH scan) jobs that were dropped when CI moved to the reusable workflows — wired into gate's required results.
  • files.test.tsx's 20s timeout is pre-existing on main (no diff to that file since the merge-base) — not touched here, flagging per review guidance rather than chasing it.

Validated with actionlint -config-file .github/actionlint.yaml (clean) plus the local verifications above. codex/fleet-alignment-reviewable-20260730 (#2) is superseded by this branch (identical content plus a workflow-ref repin) and has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant