Skip to content

fix(release): use explicit npm version updater - #158

Merged
jmagar merged 1 commit into
mainfrom
fix/release-please-package-version
Aug 2, 2026
Merged

fix(release): use explicit npm version updater#158
jmagar merged 1 commit into
mainfrom
fix/release-please-package-version

Conversation

@jmagar

@jmagar jmagar commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Problem

The post-merge release-please workflow for commit 20868234 failed with:

release-please failed: value at path package.version is not tagged

release-please-config.json used an implicit bare extra-file entry for packages/cortex-rmcp/package.json, while binaryVersion already used an explicit JSON updater. The implicit updater no longer resolves the scoped npm package version correctly.

Fix

  • replace the bare package.json extra-file entry with an explicit JSON updater for $.version
  • retain the explicit updater for $.binaryVersion
  • add a structural workflow contract requiring both JSON paths and forbidding the implicit updater

Verification

  • configuration remains valid JSON
  • workflow contract parses the configuration structurally
  • PR CI will exercise formatting, tests, Clippy, and repository contracts
  • after merge, the decisive verification is a green release-please workflow on main

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a release-please post-merge failure by switching the packages/cortex-rmcp/package.json entry from an implicit extra-file updater to an explicit JSON updater for $.version, aligning it with the already-explicit $.binaryVersion updater and adding a test contract to prevent regressions.

Changes:

  • Replace the bare packages/cortex-rmcp/package.json extra-files entry with an explicit { type: "json", jsonpath: "$.version" } updater.
  • Add a structural test contract that requires explicit JSON updaters for both $.version and $.binaryVersion, and forbids the implicit string-style updater.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/workflow_shapes.rs Adds a structural assertion that release-please-config.json contains explicit JSON updaters for packages/cortex-rmcp/package.json ($.version and $.binaryVersion) and forbids the implicit string entry.
release-please-config.json Updates extra-files to use an explicit JSON updater for $.version instead of the implicit extra-file entry for the npm package.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jmagar
jmagar merged commit aed693b into main Aug 2, 2026
19 checks passed
@jmagar
jmagar deleted the fix/release-please-package-version branch August 2, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants