Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy ci #267

Merged
merged 3 commits into from
Sep 16, 2024
Merged

clippy ci #267

merged 3 commits into from
Sep 16, 2024

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Sep 11, 2024

  • Fixes clippy warnings
  • forbid warnings within CI
Addressed doubts

I'm not too sure what to do about this error:

warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
  --> crates/parry3d/../../src/transformation/polygon_intersection.rs:48:21
   |
48 |     pub fn to_point(&self, pts: &[Point2<Real>]) -> Point2<Real> {
   |                     ^^^^^
   |
   = help: consider choosing a less ambiguous name
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
   = note: `#[warn(clippy::wrong_self_convention)]` on by default

Fixed by taking full ownership of self (It's not a big deal because they are Copy.

@Vrixyz Vrixyz changed the title clippy ci to forbid warnings + use expect clippy ci Sep 11, 2024
@Vrixyz Vrixyz merged commit 1cdd453 into dimforge:master Sep 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant