Skip to content

docs: fix documentation on strides #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025
Merged

Conversation

wowinter13
Copy link
Contributor

@wowinter13 wowinter13 commented Jan 14, 2025

Resolves #1217

@wowinter13
Copy link
Contributor Author

@Ralith Could you please check this one?

@Ralith
Copy link
Collaborator

Ralith commented Mar 19, 2025

I see why you found the current text misleading, but I don't find the new text much clearer; I still had to stare at them both for a few minutes to understand what was going on.

How about something like "the relative offset in the underlying storage corresponding to a change in position by one row or column respectively"?

@wowinter13
Copy link
Contributor Author

@Ralith thanks, addressed!
Sorry for the delay – forgot about this PR

@Ralith
Copy link
Collaborator

Ralith commented Jun 6, 2025

No worries.

@Ralith Ralith merged commit fa7afd5 into dimforge:main Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing documentation on strides
2 participants