Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add alga crate dependency in order to use MatrixN::transform_point #372

Closed
Jbat1Jumper opened this issue Aug 29, 2018 · 5 comments
Closed
Labels
Milestone

Comments

@Jbat1Jumper
Copy link

While reading the user guide on Using raw transformation matrices on points and vectors1, I saw that it mentions the transform_point and transform_vector methods but doesn't say that in order to use them you must bring the alga::linear::Transformation trait to scope. Looking at the source code in the doc and the example2 make it clear, but at first it was a little misleading.

I didn't found another way to use those methods that adding the alga crate to my Cargo.toml. So I was thinking, would it be a good idea to reexport the alga::linear::Transformation? Or is it better to leave it like that and just add a comment in the documentation?

@sebcrozet
Copy link
Member

I agree the documentation should clarify the fact the alga::linear::Transformation trait must be imported.

For now, I'd prefer not to reexport the trait to keep it clear the abstract traits cone from alga.

@sebcrozet
Copy link
Member

Closing this in favor of dimforge/nalgebra.rs#6

@Ralith
Copy link
Collaborator

Ralith commented Sep 4, 2018

Would it make sense to wrap these trait methods as inherent methods for convenience?

@sebcrozet
Copy link
Member

That can be considered if that makes it easier to use, yes.

@sebcrozet
Copy link
Member

This was fixed by #457. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants