Ba/filter participant #1781
Merged
Ba/filter participant #1781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
snopoke
reviewed
Jun 26, 2025
There was a problem hiding this comment.
generally looks good but I don't think we should load all the participants into the view.
Have a look at the Ajax Loading, Custom Scoring, and Inline Display example. This will require a new 'particpant_api' view for internal use.
SmittieC
reviewed
Jun 30, 2025
snopoke
approved these changes
Jul 2, 2025
| @@ -231,6 +233,24 @@ | |||
| window.addEventListener('popstate', () => { | |||
| this.setLabelFromURL(); | |||
| }); | |||
| fetch("{% url 'participants:participant_identifier' team.slug experiment.id %}", { | |||
There was a problem hiding this comment.
I still think this should be dynamic as in it does a query on demand to search for the participants but let's merge this as is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add any of operator for participant column. Closes #1479
Used a slightly hacky approach: included the any of operator under the string type and handled it as a choice to support multiselect behavior.
User Impact
Demo
Demo
Docs and Changelog