Reinstate auto select revert

[shubham1g5]

Product Description

Alternate implementation for skipping auto-select menu from contextual menus

Original PR
Revert PR
Jira

Technical Summary

Reverts original solution implemented in favor of a simple check before adding the entity list menu to contextual menus.

Safety Assurance

In addition to the unit test, I tested the correspondix fix on staging as per the steps outlined in this comment.

Safety story

Automated test coverage

PR adds a regression test for the issue that caused the revert.

QA Plan

None

Special deploy instructions

• This PR can be deployed after merge with no further considerations.

Rollback instructions

• This PR can be reverted after deploy with no further considerations.

Review

• The set of people pinged as reviewers is appropriate for the level of risk of the change.

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.25%. Comparing base (0db681d) to head (e85efc5).
Report is 15 commits behind head on master.

Files with missing lines	Patch %	Lines
...a/org/commcare/formplayer/session/MenuSession.java	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1649      +/-   ##
============================================
+ Coverage     70.21%   70.25%   +0.04%     
- Complexity     2005     2011       +6     
============================================
  Files           254      254              
  Lines          7902     7904       +2     
  Branches        744      745       +1     
============================================
+ Hits           5548     5553       +5     
  Misses         2070     2070              
+ Partials        284      281       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Jtang-1]

The changes look fine and seem to exclude the autoselect entity screen from the persistent menu. But, does this address the root cause of the issue? I think that selecting a form or any screen after the autoselect process would still result in an error? Demonstrated by the workflow shown in this screen recording (the screen recording shows the original behavior - it didn't pull in this PR)

[shubham1g5]

@Jtang-1 That issue was only present with persistent menu navigations (And not the main in-screen navigation) due to us trying to make a case selection on a auto-select screen with a guid. We solved it by removing the menu item from persistent menu entirely as that's indeed the behaviour we want, although you are right that if we try to make a selection on auto-selection screen with selections[] containing the guid of the selection, that issue may rise again but that'll be us supplying incorrect input to FP apis and something we should never intent to do