Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default log levels #1461

Merged
merged 1 commit into from
Sep 13, 2023
Merged

set default log levels #1461

merged 1 commit into from
Sep 13, 2023

Conversation

snopoke
Copy link
Contributor

@snopoke snopoke commented Sep 13, 2023

Technical Summary

This is mostly for convenience in dev to reduce the amount of verbose logs.

Safety Assurance

Safety story

Change to default application properties which to configure logging should not have any impact in production.

QA Plan

None

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

@snopoke snopoke added the product/invisible Change has no end-user visible impact label Sep 13, 2023
@snopoke snopoke requested a review from shubham1g5 September 13, 2023 07:41
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #1461 (6962a4d) into master (17c1206) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1461   +/-   ##
=========================================
  Coverage     69.70%   69.70%           
  Complexity     1920     1920           
=========================================
  Files           246      246           
  Lines          7545     7545           
  Branches        677      677           
=========================================
  Hits           5259     5259           
  Misses         2022     2022           
  Partials        264      264           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snopoke snopoke merged commit 4ffbdcc into master Sep 13, 2023
4 checks passed
@snopoke snopoke deleted the sk/default-logging branch September 13, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants